Trevor PaughSystems engineer
Trevor PaughProject Chronicles

Chronicles / The Factory

Reviewers see the screenshots

Design

The user-experience and visual-design reviewers now look at the tester's screenshots instead of only the code, and a job that changes the interface cannot pass without a capture.

The two design reviewers had been reading diffs. They could judge the wording of a label and the structure of a page from the markup, but they could not see the app, which is the thing they exist to judge. Job 012 on the site, a visible change to the board, went through with no capture at all.

The tester’s pictures

The tester already runs the feature; it now takes screenshots as it goes, and the two design reviewers read those alongside the code. For a job marked as a user-interface change, a missing screenshot is a failed review, not a skipped one.